From 38a5b5ba825f8324545bdefb6ef7e53e20458d66 Mon Sep 17 00:00:00 2001 From: fmkiotheka <fmkiotheka@inf.ufpr.br> Date: Tue, 17 Jun 2025 13:13:27 -0300 Subject: [PATCH] fix: update only newly created MACs --- netbox_proxmox_sync/api/netbox/update.py | 10 ++++------ setup.py | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/netbox_proxmox_sync/api/netbox/update.py b/netbox_proxmox_sync/api/netbox/update.py index 2255e50..ab56047 100644 --- a/netbox_proxmox_sync/api/netbox/update.py +++ b/netbox_proxmox_sync/api/netbox/update.py @@ -95,18 +95,16 @@ def vms_and_interfaces(cluster_id): NB_API.virtualization.interfaces.update(updated_i) created_interfaces = NB_API.virtualization.interfaces.create(created_i) # MAC Address fixup step - NB_API.dcim.mac_addresses.create([{ + created_mac_addresses = NB_API.dcim.mac_addresses.create([{ 'mac_address': i['mac_address'], 'assigned_object_id': ci['id'], 'assigned_object_type': 'virtualization.vminterface' } for i, ci in zip(created_i, created_interfaces)]) updated_m = [] - for mac_address in NB_API.dcim.mac_addresses.filter( - mac_address=[i['mac_address'] for i in created_i] - ): + for mac_address in created_mac_addresses: updated_m.append({ - 'id': mac_address.assigned_object_id, - 'primary_mac_address': mac_address.id, + 'id': mac_address['assigned_object_id'], + 'primary_mac_address': mac_address['id'], }) NB_API.virtualization.interfaces.update(updated_m) diff --git a/setup.py b/setup.py index 3753c97..3eea31b 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ from setuptools import find_packages, setup setup( name='netbox-proxmox-sync', - version='2.2.2', + version='2.2.3', description='Import Proxmox cluster info into NetBox.', install_requires=['pynetbox', 'proxmoxer'], include_package_data=True, -- GitLab