Skip to content

GitLab

Merged
Created by Vytor Calixto@vsbc14👾Guest

Issue 18

Changes:

  • Old dimensions middleware is now called parseParams middleware and can be used with the dimensions and filters (and metrics)
  • API-like url used
  • The query middleware now converts the squel object in req.sql to the correct format (using .toParam())
  • The squel object is being "injected" in the requisition in the app.js. All routes have now, by default, a req.sql object

Closes simcaq/SCRUM#18

CC: @jvtr12 @rce16 @jdo @gas15

Future work:

The way the sql is being constructed is still messy. See this function. There should be a better way to do the joins. I don't know if the field selection and the where inclusion also can be improved.